-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add batching capability to the old QueueConfig #12746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batching capability to the old QueueConfig #12746
Conversation
336ebaa
to
c6dd425
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
c6dd425
to
45d5d51
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (74.54%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12746 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 479 479
Lines 26491 26468 -23
=======================================
- Hits 24262 24242 -20
+ Misses 1757 1756 -1
+ Partials 472 470 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f09817e
Hey @dmitryax and @bogdandrutu, what's the context of this PR? Why does it have no description? Why is this being done? There are plenty of breaking changes here, it would be nice to let people know why they are being made, what's the plan, objectives, etc. |
component: exporterhelper | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Deprecate `QueueConfig` in favor of `QueueBatchConfig`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have include some information about how this will affect the otlp
and otlphttp
exporters?
No description provided.